Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add --insecure to skip TLS certificate verification #1769

Merged
merged 3 commits into from
Jun 13, 2024
Merged

fix: add --insecure to skip TLS certificate verification #1769

merged 3 commits into from
Jun 13, 2024

Conversation

safeer
Copy link
Contributor

@safeer safeer commented Jun 13, 2024

Fixes #1738

@safeer safeer requested a review from alecthomas as a code owner June 13, 2024 17:20
@safeer safeer requested review from a team and matt2e and removed request for a team June 13, 2024 17:20
@ftl-robot ftl-robot mentioned this pull request Jun 13, 2024
Open
@safeer
Copy link
Contributor Author

safeer commented Jun 13, 2024

Screenshot 2024-06-13 at 2 01 43 PM gosec does not like this change

@safeer safeer force-pushed the saf/insecure-skip-tls-verification branch from fd819bb to 36c8da2 Compare June 13, 2024 23:10
@safeer safeer merged commit 63fb100 into main Jun 13, 2024
41 checks passed
@safeer safeer deleted the saf/insecure-skip-tls-verification branch June 13, 2024 23:20
@matt2e matt2e added the approved Marks an already closed PR as approved label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas alecthomas approved these changes

@matt2e matt2e Awaiting requested review from matt2e

Assignees
No one assigned
Labels
approved Marks an already closed PR as approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an option to disable certificate checking on the ftl cli
3 participants
@safeer @alecthomas @matt2e