Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: unit testing #1765

Merged
merged 3 commits into from
Jun 13, 2024
Merged

docs: unit testing #1765

merged 3 commits into from
Jun 13, 2024

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Jun 13, 2024

closes #1679

@matt2e matt2e requested a review from alecthomas as a code owner June 13, 2024 06:35
@matt2e matt2e requested review from a team and wesbillman and removed request for a team June 13, 2024 06:35
@ftl-robot ftl-robot mentioned this pull request Jun 13, 2024
Open
@matt2e matt2e force-pushed the matt2e/test-docs branch from 14a7484 to cead1b9 Compare June 13, 2024 06:38
@matt2e matt2e changed the title doc: unit testing docs: unit testing Jun 13, 2024
alecthomas
alecthomas approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

docs/content/docs/reference/unittests.md Outdated Show resolved Hide resolved
docs/content/docs/reference/unittests.md Outdated Show resolved Hide resolved
wesbillman
wesbillman approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@wesbillman wesbillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So good! I learned a few things reviewing this as well. Thanks for putting this together.

matt2e and others added 2 commits June 14, 2024 09:46
@matt2e @alecthomas
fix typo
ecf77f3 
Co-authored-by: Alec Thomas <[email protected]>
@matt2e @alecthomas
fix type safety on WhenMap
16d5167 
Co-authored-by: Alec Thomas <[email protected]>
@matt2e matt2e merged commit 1eb6d84 into main Jun 13, 2024
41 checks passed
@matt2e matt2e deleted the matt2e/test-docs branch June 13, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas alecthomas approved these changes

@wesbillman wesbillman wesbillman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to use ftltest
3 participants
@matt2e @alecthomas @wesbillman