fix: pubsub schema fixes #1743
Merged
fix: pubsub schema fixes #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
matt2e
commented
Jun 12, 2024
| @@ -286,9 +286,6 @@ func TestExtractModuleSchemaNamedTypes(t *testing.T) { | |||
| t.SkipNow() | |||
| } | |||
| assert.NoError(t, prebuildTestModule(t, "testdata/named", "testdata/namedext")) | |||
| if testing.Short() { | |||
There was a problem hiding this comment.
These were redundant as they are repeated a few lines earlier
matt2e
force-pushed
the
matt2e/pubsub-schema-fixes
branch
from
b7528e9 to
c30eb93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes fixes for the following cases:
.Objfield, possibly because it was defined in a different file. Added a map from variable declaration position to the schema.Topic, and used that insteadexternal.DoSomething(ctx), and an allowed field access (eg:external.Data{}.Name)