fix: module dir paths and lsp error unwrapping #1705
Conversation
wesbillman
requested review from
a team,
deniseli and
worstell
and removed request for
a team
| } | ||
|
|
||
| return []string{"."} |
There was a problem hiding this comment.
Since "." is not an absolute path, do you want to update that to be absolute in this function as well?
There was a problem hiding this comment.
Yeah good question! Maybe we should just add this absolute path when parsing/merge if there's nothing in the toml file. Then this would just return the absModuleDirs instead of "."
| @@ -78,9 +78,12 @@ func (s *Server) post(err error) { | |||
| errUnspecified := []error{} | |||
|
|
|||
| // Deduplicate and associate by filename. | |||
| for _, err := range ftlErrors.DeduplicateErrors(ftlErrors.UnwrapAll(err)) { | |||
| for _, e := range ftlErrors.DeduplicateErrors(ftlErrors.UnwrapAll(err)) { | |||
| if !ftlErrors.Innermost(e) { | |||
There was a problem hiding this comment.
All @worstell here 😂
wesbillman
force-pushed
the
fix-module-paths-and-lsp-errors
branch
from
859a64e to
b5b946d
Compare
| @@ -32,16 +32,12 @@ type Config struct { | |||
| ExternalDirs []string `toml:"external-dirs"` | |||
| Commands Commands `toml:"commands"` | |||
| FTLMinVersion string `toml:"ftl-min-version"` | |||
| absModuleDirs []string | |||
There was a problem hiding this comment.
This feels a bit gross, but I don't have any better ideas.
There was a problem hiding this comment.
I had exactly the same feeling. I'm also not 100% sure how we want the abs paths to be computed given that it's possible reference multiple ftl-project.toml files, but those files could be at different paths. Which, is what led me to this approach so that at least the modules will be relative to the ftl-project.toml file.
Definitely feels like this will need more thought in the future though.
There was a problem hiding this comment.
Yeah, and also the working directory of the process could change after construction, so we can't rely on dynamically making them absolute. It seems like the best solution.
|
Unrelated but why is that error duplicated three times? Can we fix that? |
This fixes clearing of errors from the lsp when modules are being rebuilt and improves duplication of errors (thanks @worstell!!)