Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes for behaviour regressions #1698

Merged
merged 1 commit into from
Jun 7, 2024
Merged

fix: fixes for behaviour regressions #1698

merged 1 commit into from
Jun 7, 2024

Conversation

alecthomas
Copy link
Collaborator

  • 46b7c97. was writing absolute paths into ftl-project.toml
  • ftl config/secret get were not writing raw JSON values

@alecthomas alecthomas requested review from a team and deniseli and removed request for a team June 7, 2024 02:44
@ftl-robot ftl-robot mentioned this pull request Jun 7, 2024
- 46b7c97. was writing absolute paths
  into `ftl-project.toml`
- `ftl config/secret get` were not writing raw JSON values
@alecthomas alecthomas merged commit ce30b17 into main Jun 7, 2024
37 checks passed
@alecthomas alecthomas deleted the aat/fixes branch June 7, 2024 02:54
@wesbillman wesbillman added the approved Marks an already closed PR as approved label Jun 7, 2024
Copy link
Contributor

@deniseli deniseli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice thanks for fixing all these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Marks an already closed PR as approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants