Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: re-enable ftl config/secret working without a running controller #1695

Merged
merged 2 commits into from
Jun 7, 2024
Merged

fix: re-enable ftl config/secret working without a running controller #1695

merged 2 commits into from
Jun 7, 2024

Conversation

deniseli
Copy link
Contributor

@deniseli deniseli commented Jun 6, 2024

Fixes #1677

Without starting a controller first, you can once again run ftl config/secret commands:

$ ftl config list
key
echo.default

@deniseli deniseli marked this pull request as ready for review June 7, 2024 00:00
@deniseli deniseli requested a review from alecthomas as a code owner June 7, 2024 00:00
@deniseli deniseli requested review from a team and wesbillman and removed request for a team June 7, 2024 00:00
@ftl-robot ftl-robot mentioned this pull request Jun 7, 2024
Open
@deniseli deniseli force-pushed the dli/configsecret-no-controller branch from d2187e7 to a3dcc50 Compare June 7, 2024 00:01
@deniseli
init
50aecf8 
lint

hostname parsing

start filling out the local interface

move files to admin package and fill out interface methods

integration test

integration test

harness

use loopback instead of hardcoding IPs

better comment
@deniseli deniseli force-pushed the dli/configsecret-no-controller branch from a3dcc50 to 50aecf8 Compare June 7, 2024 00:01
@deniseli deniseli requested a review from safeer June 7, 2024 00:03
alecthomas
alecthomas approved these changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naisu!

backend/controller/admin/cmd_client.go Outdated Show resolved Hide resolved
backend/controller/admin/cmd_client.go Outdated Show resolved Hide resolved
backend/controller/admin/local_cmd_client.go Outdated Show resolved Hide resolved
@deniseli deniseli merged commit e2007f7 into main Jun 7, 2024
37 checks passed
@deniseli deniseli deleted the dli/configsecret-no-controller branch June 7, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas alecthomas approved these changes

@wesbillman wesbillman Awaiting requested review from wesbillman

@safeer safeer Awaiting requested review from safeer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow ftl config/secret to run without the controller
2 participants
@deniseli @alecthomas