Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pubsub retries #1683

Merged
merged 4 commits into from
Jun 6, 2024
Merged

feat: pubsub retries #1683

merged 4 commits into from
Jun 6, 2024

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Jun 6, 2024

No description provided.

@ftl-robot ftl-robot mentioned this pull request Jun 6, 2024
@matt2e matt2e force-pushed the matt2e/pubsub-retry branch from cb192d3 to b36daf8 Compare June 6, 2024 05:12
@matt2e matt2e marked this pull request as ready for review June 6, 2024 05:41
@matt2e matt2e requested a review from alecthomas as a code owner June 6, 2024 05:41
@matt2e matt2e requested review from a team and deniseli and removed request for a team June 6, 2024 05:41
// check that there are the right amount of failed async calls
in.QueryRow("ftl",
fmt.Sprintf(`
SELECT COUNT(*)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indent the SQL

return nil
}

var _ = ftl.Subscription(publisher.Topic2, "doomed_subscription")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@matt2e matt2e force-pushed the matt2e/pubsub-retry branch from 1b2a736 to f775a86 Compare June 6, 2024 06:32
@matt2e matt2e merged commit c9d63f8 into main Jun 6, 2024
36 checks passed
@matt2e matt2e deleted the matt2e/pubsub-retry branch June 6, 2024 06:38
@matt2e matt2e mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants