fix: default to root when module-dirs is not set #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
alecthomas
approved these changes
Jun 6, 2024
| @@ -34,6 +34,15 @@ type Config struct { | |||
| FTLMinVersion string `toml:"ftl-min-version"` | |||
| } | |||
|
|
|||
| // MustGetModuleDirs returns the module-dirs field from the ftl-project.toml, unless that | |||
| // is not defined, in which case it defaults to the root directory. | |||
| func (c Config) MustGetModuleDirs() []string { | |||
There was a problem hiding this comment.
"MustX" is a pattern in Go that means "must get this thing or panic on error", so can we maybe call this "ModuleDirsOrDefault()" instead?
There was a problem hiding this comment.
Whoops! Thanks thanks, that's way better
test simplify project toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1668
Note that this isn't usable in the
ftlrepo itself becausego-runtime/scaffolding/{{ .Name | camel | lower }}/ftl.tomlconfuses the walker, so we do need to specifyexamples/goin our ownftl-project.toml. However, the change does WAI in normal repositories that don't have module templates.