fix: handle async call not being able to be called #1663
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes case where async call's early failure skipped clean up and retries.
Issue steps:
callWithRequest(...)
getActiveSchema
which gets the schema filtering byminReplicas > 0 and r.assigned = 'assigned'
(link)callWithRequest(...)
fails because this new module is not in the fetched schemaexecuteAsyncCalls(...)
return early due to this error, not updating the state of the async callexecuteAsyncCalls(...)
)executing
and no leaseSo this async call gets stuck forever. For pubsub this means the subscription stops forever.