Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AdminService: move to admin package, add tests #1656

Merged
merged 3 commits into from
Jun 5, 2024
Merged

fix: AdminService: move to admin package, add tests #1656

merged 3 commits into from
Jun 5, 2024

Conversation

safeer
Copy link
Contributor

@safeer safeer commented Jun 5, 2024

No description provided.

@safeer safeer requested review from wesbillman and deniseli June 5, 2024 00:16
@safeer safeer requested a review from alecthomas as a code owner June 5, 2024 00:16
@safeer safeer requested review from a team and worstell and removed request for a team June 5, 2024 00:16
@ftl-robot ftl-robot mentioned this pull request Jun 5, 2024
Open
@safeer safeer force-pushed the adminservice-test branch 2 times, most recently from bff0074 to 546d7f8 Compare June 5, 2024 00:22
@safeer safeer marked this pull request as draft June 5, 2024 00:44
@safeer safeer force-pushed the adminservice-test branch from 2da32ec to f99ec2d Compare June 5, 2024 00:46
@safeer safeer marked this pull request as ready for review June 5, 2024 00:51
deniseli
deniseli reviewed Jun 5, 2024
View reviewed changes
Copy link
Contributor

@deniseli deniseli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niiiiice

backend/controller/admin/admin_test.go Outdated Show resolved Hide resolved
backend/controller/admin/admin_test.go Outdated Show resolved Hide resolved
backend/controller/admin/admin_test.go Show resolved Hide resolved
backend/controller/admin/admin_test.go Show resolved Hide resolved
backend/controller/admin/admin_test.go Show resolved Hide resolved
alecthomas
alecthomas approved these changes Jun 5, 2024
View reviewed changes
backend/controller/admin/admin_test.go Outdated Show resolved Hide resolved
@safeer safeer force-pushed the adminservice-test branch from f99ec2d to 6a80677 Compare June 5, 2024 21:39
@safeer safeer merged commit f04a921 into main Jun 5, 2024
32 checks passed
@safeer safeer deleted the adminservice-test branch June 5, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deniseli deniseli deniseli left review comments

@alecthomas alecthomas alecthomas approved these changes

@wesbillman wesbillman Awaiting requested review from wesbillman

@worstell worstell Awaiting requested review from worstell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@safeer @alecthomas @deniseli