generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create specified config files that do not exist #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
alecthomas
reviewed
May 31, 2024
alecthomas
reviewed
Jun 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a couple of minor changes
deniseli
force-pushed
the
dli/config-create
branch
2 times, most recently
from
June 1, 2024 01:57
3c64b02
to
da89766
Compare
deniseli
force-pushed
the
dli/config-create
branch
from
June 3, 2024 18:36
ad4dd5c
to
003b748
Compare
deniseli
force-pushed
the
dli/config-create
branch
from
June 4, 2024 02:59
4a41beb
to
b029b5a
Compare
alecthomas
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jonathanj-square
pushed a commit
that referenced
this pull request
Jun 4, 2024
Fixes: #1561 ``` $ rm ftl-project-idk.toml $ ftl config set yo --inline value -C ftl-project-idk.toml warn: Creating a new project config file at "ftl-project-idk.toml" because the file does not already exist $ ftl config set yo --inline value -C ftl-project-idk.toml $ stat ftl-project-idk.toml 16777232 3291117 -rw------- 1 dli staff 0 125 "Jun 3 22:44:16 2024" "Jun 3 22:44:15 2024" "Jun 3 22:44:15 2024" "Jun 3 22:44:15 2024" 4096 8 0 ftl-project-idk.toml $ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1561