Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create specified config files that do not exist #1618

Merged
merged 8 commits into from
Jun 4, 2024

Conversation

deniseli
Copy link
Contributor

@deniseli deniseli commented May 31, 2024

Fixes: #1561

$ rm ftl-project-idk.toml
$ ftl config set yo --inline value -C ftl-project-idk.toml
warn: Creating a new project config file at "ftl-project-idk.toml" because the file does not already exist
$ ftl config set yo --inline value -C ftl-project-idk.toml
$ stat ftl-project-idk.toml                         
16777232 3291117 -rw------- 1 dli staff 0 125 "Jun  3 22:44:16 2024" "Jun  3 22:44:15 2024" "Jun  3 22:44:15 2024" "Jun  3 22:44:15 2024" 4096 8 0 ftl-project-idk.toml
$

@deniseli deniseli requested a review from alecthomas as a code owner May 31, 2024 21:56
@deniseli deniseli requested review from a team and matt2e and removed request for a team May 31, 2024 21:56
@ftl-robot ftl-robot mentioned this pull request May 31, 2024
cmd/ftl/main.go Outdated Show resolved Hide resolved
cmd/ftl/main.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of minor changes

common/projectconfig/projectconfig.go Outdated Show resolved Hide resolved
integration/integration_test.go Outdated Show resolved Hide resolved
@deniseli deniseli force-pushed the dli/config-create branch 2 times, most recently from 3c64b02 to da89766 Compare June 1, 2024 01:57
@deniseli deniseli force-pushed the dli/config-create branch from ad4dd5c to 003b748 Compare June 3, 2024 18:36
@deniseli deniseli force-pushed the dli/config-create branch from 4a41beb to b029b5a Compare June 4, 2024 02:59
Copy link
Collaborator

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@deniseli deniseli merged commit d4c9753 into main Jun 4, 2024
31 checks passed
@deniseli deniseli deleted the dli/config-create branch June 4, 2024 03:15
jonathanj-square pushed a commit that referenced this pull request Jun 4, 2024
Fixes: #1561

```
$ rm ftl-project-idk.toml
$ ftl config set yo --inline value -C ftl-project-idk.toml
warn: Creating a new project config file at "ftl-project-idk.toml" because the file does not already exist
$ ftl config set yo --inline value -C ftl-project-idk.toml
$ stat ftl-project-idk.toml                         
16777232 3291117 -rw------- 1 dli staff 0 125 "Jun  3 22:44:16 2024" "Jun  3 22:44:15 2024" "Jun  3 22:44:15 2024" "Jun  3 22:44:15 2024" 4096 8 0 ftl-project-idk.toml
$
```
@matt2e matt2e added the approved Marks an already closed PR as approved label Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Marks an already closed PR as approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should ftl secret set create a project toml if one is specified that doesn't exist?
3 participants