fix: treat type aliased subpackage types as underlying types #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
alecthomas
approved these changes
May 23, 2024
matt2e
force-pushed
the
matt2e/treat-subpackage-typealiases-as-underlying
branch
from
e753bbc to
3790c46
Compare
deniseli
reviewed
May 23, 2024
|
|
||
| import ( | ||
| "context" | ||
| // Import the FTL SDK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was found when trying to upgrade ftl with another codebase:
subpackage.CustomerTypetype CustomerType stringPreviously this would get added to the schema as just
String, but our recent changes had made it get added to the schema asmodule.CustomerTypeWe now detect this case and use the underlying type like we used to.