feat: ftl secret --op can now write to 1password, fixes #1537
#1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Essentially a rewrite so the diff is very messy. Worth just looking at the whole file. |
alecthomas
reviewed
May 22, 2024
alecthomas
approved these changes
May 22, 2024
|
This is awesome, thanks @gak |
deniseli
reviewed
May 23, 2024
| func checkOpBinary() error { | ||
| _, err := exec.LookPath("op") | ||
| if err != nil { | ||
| return fmt.Errorf("1Password CLI tool \"op\" not found: %w", err) |
There was a problem hiding this comment.
No need to fix this instance, but convenience fyi for the future - you can denote a string with backticks to avoid having to escape all the quotes inside it:
`my "quoted" string`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a
1passwordtagged test.