Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove old deployment dirs (#1463) #1474

Merged
merged 1 commit into from
May 14, 2024
Merged

feat: remove old deployment dirs (#1463) #1474

merged 1 commit into from
May 14, 2024

Conversation

gak
Copy link
Contributor

@gak gak commented May 14, 2024

No description provided.

@gak gak requested a review from alecthomas as a code owner May 14, 2024 04:28
@gak gak requested review from a team and matt2e and removed request for a team May 14, 2024 04:28
ControllerEndpoint *url.URL `name:"ftl-endpoint" help:"Controller endpoint." env:"FTL_ENDPOINT" default:"http://localhost:8892"`
TemplateDir string `help:"Template directory to copy into each deployment, if any." type:"existingdir"`
DeploymentDir string `help:"Directory to store deployments in." default:"${deploymentdir}"`
DeploymentKeepHistory int `help:"Number of deployments to keep history for." default:"3"`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added DeploymentKeepHistory

@alecthomas alecthomas mentioned this pull request May 14, 2024
Copy link
Collaborator

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gak gak merged commit 1e079ab into main May 14, 2024
11 checks passed
@gak gak deleted the gak/gc-deploy-dirs branch May 14, 2024 04:31
@matt2e matt2e added the approved Marks an already closed PR as approved label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Marks an already closed PR as approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants