-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace inmemoryprovider with inlineprovider #1348
Conversation
@@ -21,13 +21,13 @@ func TestConfigPriority(t *testing.T) { | |||
|
|||
moduleName := "test" | |||
|
|||
cp := cf.NewInMemoryProvider[cf.Configuration]() | |||
cp := cf.InlineProvider[cf.Configuration]{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use cf.InlineProvider[cf.Configuration]{Inline: true}
to fix the test failure IIRC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just saw the same thing 👍
@@ -33,7 +33,9 @@ func FromProto(ctx context.Context, response *ftlv1.ModuleContextResponse) (*Mod | |||
} | |||
|
|||
func newInMemoryConfigManager[R cf.Role](ctx context.Context, config map[string][]byte) (*cf.Manager[R], error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be renamed?
In-memory provider was being used to hold config and secrets in memory, but inline provider already solved that. Removing to simplify things