Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace inmemoryprovider with inlineprovider #1348

Merged
merged 3 commits into from
Apr 28, 2024

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Apr 28, 2024

In-memory provider was being used to hold config and secrets in memory, but inline provider already solved that. Removing to simplify things

@matt2e matt2e requested a review from a team as a code owner April 28, 2024 23:05
@matt2e matt2e requested review from worstell and removed request for a team April 28, 2024 23:05
@alecthomas alecthomas mentioned this pull request Apr 28, 2024
@@ -21,13 +21,13 @@ func TestConfigPriority(t *testing.T) {

moduleName := "test"

cp := cf.NewInMemoryProvider[cf.Configuration]()
cp := cf.InlineProvider[cf.Configuration]{}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use cf.InlineProvider[cf.Configuration]{Inline: true} to fix the test failure IIRC.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw the same thing 👍

@matt2e matt2e merged commit f8ce99d into main Apr 28, 2024
11 checks passed
@matt2e matt2e deleted the matt2e/remove-inmemory-provider branch April 28, 2024 23:22
@@ -33,7 +33,9 @@ func FromProto(ctx context.Context, response *ftlv1.ModuleContextResponse) (*Mod
}

func newInMemoryConfigManager[R cf.Role](ctx context.Context, config map[string][]byte) (*cf.Manager[R], error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be renamed?

@worstell worstell added the approved Marks an already closed PR as approved label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Marks an already closed PR as approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants