Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix linter warnings in terminal #1302

Merged
merged 1 commit into from
Apr 18, 2024
Merged

chore: fix linter warnings in terminal #1302

merged 1 commit into from
Apr 18, 2024

Conversation

wesbillman
Copy link
Collaborator

I was getting these warnings when running go linting.

./bin/golangci-lint run
WARN [config_reader] The configuration option `run.skip-files` is deprecated, please use `issues.exclude-files`.
WARN [config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`.
WARN [config_reader] The configuration option `govet.check-shadowing` is deprecated. Please enable `shadow` instead, if you are not using `enable-all`.

@wesbillman wesbillman requested a review from a team as a code owner April 18, 2024 15:25
@wesbillman wesbillman requested review from matt2e and removed request for a team April 18, 2024 15:25
@alecthomas alecthomas mentioned this pull request Apr 18, 2024
Open
@wesbillman wesbillman merged commit 7e1034d into main Apr 18, 2024
12 checks passed
@wesbillman wesbillman deleted the fix-linter-warnings branch April 18, 2024 17:30
@matt2e matt2e added the approved Marks an already closed PR as approved label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt2e matt2e Awaiting requested review from matt2e matt2e was automatically assigned from TBD54566975/ftl-team

Assignees
No one assigned
Labels
approved Marks an already closed PR as approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wesbillman @matt2e