feat: simplify config/secret API #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
requested review from
dhanji,
wesbillman,
worstell and
matt2e
as code owners
Open
alecthomas
force-pushed
the
aat/simplify-config
branch
from
5cc3f1e to
579f7e4
Compare
Rather than `ftl.Config[string]("foo").Get(ctx)` it is now
`ftl.Config[string]("foo")`.
alecthomas
force-pushed
the
aat/simplify-config
branch
from
579f7e4 to
6f68fb4
Compare
alecthomas
added a commit
that referenced
this pull request
Apr 12, 2024
This reverts commit 2f3fc07.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than
ftl.Config[string]("foo").Get(ctx)it is nowftl.Config[string]("foo").Get().