Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When we terminate a runner don't spam cancel errors. #534

Closed
wesbillman opened this issue Nov 2, 2023 · 0 comments · Fixed by #537
Closed

When we terminate a runner don't spam cancel errors. #534

wesbillman opened this issue Nov 2, 2023 · 0 comments · Fixed by #537
Labels
enhancement New feature or request

Comments

@wesbillman
Copy link
Collaborator

Like this type of stuff...

info:reconcileRunners: Removing runner: R0000000000000000000000E000
error:reconcileRunners: Error starting runner: context canceled: context canceled
warn:runner5: Stream handler failed, retrying in 100ms: context canceled
warn:runner5: Stream handler failed, retrying in 100ms: context canceled
error:controller0: Streaming RPC failed: invalid_argument: protocol error: incomplete envelope: stream error: stream ID 41; CANCEL: /xyz.block.ftl.v1.ControllerService/StreamDeploymentLogs
@wesbillman wesbillman added the enhancement New feature or request label Nov 2, 2023
@wesbillman wesbillman added this to the V0 - Staging dev release milestone Nov 2, 2023
@github-project-automation github-project-automation bot moved this to Todo in FTL Nov 2, 2023
alecthomas added a commit that referenced this issue Nov 2, 2023
@alecthomas
fix: suppress irrelevant log spam when scaling runners
f56377b 
Fixes #534
@alecthomas alecthomas mentioned this issue Nov 2, 2023
Merged
alecthomas added a commit that referenced this issue Nov 2, 2023
@alecthomas
fix: suppress irrelevant log spam when scaling runners (#537)
6584788 
Also added `--recreate` flag to `ftl serve`.

Fixes #534
@github-project-automation github-project-automation bot moved this from Todo to Done in FTL Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: suppress noisy log spam when scaling runners block/ftl
1 participant
@wesbillman