Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Killing the ftl interactive command causes panic #2807

Closed
wesbillman opened this issue Sep 24, 2024 · 0 comments · Fixed by #2810
Closed

Killing the ftl interactive command causes panic #2807

wesbillman opened this issue Sep 24, 2024 · 0 comments · Fixed by #2810
Labels
bug Something isn't working next Work that will be be picked up next P2

Comments

@wesbillman
Copy link
Collaborator

Start ftl dev --recreate. Wait for echo and time to deploy, then CTRL+C to kill it.

ftl dev --recreate

info:controller0: Deployed dpl-echo-43mar6x7owpoqa01
info: All modules deployed in 13.974872167s, watching for changes...
echo:  ✅  time:  ✅
panic: channel not subscribed

goroutine 69 [running]:
github.com/alecthomas/types/pubsub.(*Topic[...]).Unsubscribe(0x104b437a0, 0x14000666e00)
	/Users/wesbillman/go/pkg/mod/github.com/alecthomas/[email protected]/pubsub/pubsub.go:139 +0xb4
github.com/TBD54566975/ftl/internal/buildengine.(*Engine).watchForModuleChanges.func2()
	/Users/wesbillman/dev/ftl/internal/buildengine/engine.go:369 +0x34
github.com/TBD54566975/ftl/internal/buildengine.(*Engine).watchForModuleChanges(0x140006eb2c0, {0x104b0f0d0, 0x14000a1a690}, 0x1dcd6500)
	/Users/wesbillman/dev/ftl/internal/buildengine/engine.go:411 +0xec0
github.com/TBD54566975/ftl/internal/buildengine.(*Engine).Dev(...)
	/Users/wesbillman/dev/ftl/internal/buildengine/engine.go:337
main.(*devCmd).Run.func2()
	/Users/wesbillman/dev/ftl/frontend/cli/cmd_dev.go:102 +0x5cc
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/Users/wesbillman/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x54
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 1
	/Users/wesbillman/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x98
@wesbillman wesbillman added the bug Something isn't working label Sep 24, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Sep 24, 2024
@bradleydwyer bradleydwyer added next Work that will be be picked up next P2 labels Sep 24, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Sep 24, 2024
@ftl-robot ftl-robot mentioned this issue Sep 24, 2024
stuartwdouglas added a commit that referenced this issue Sep 24, 2024
Also some cleanup around shutdown handling

fixes: #2807
stuartwdouglas added a commit that referenced this issue Sep 24, 2024
Also some cleanup around shutdown handling

fixes: #2807
stuartwdouglas added a commit that referenced this issue Sep 24, 2024
Also some cleanup around shutdown handling

fixes: #2807
stuartwdouglas added a commit that referenced this issue Sep 24, 2024
Also some cleanup around shutdown handling

fixes: #2807
stuartwdouglas added a commit that referenced this issue Sep 24, 2024
Also some cleanup around shutdown handling

fixes: #2807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working next Work that will be be picked up next P2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants