Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition related to encryption: concurrent map writes, getDerivedPrimitive #2466

Closed
gak opened this issue Aug 20, 2024 · 1 comment · Fixed by #2444
Closed

Race condition related to encryption: concurrent map writes, getDerivedPrimitive #2466

gak opened this issue Aug 20, 2024 · 1 comment · Fixed by #2444
Assignees
@gak

Comments

@gak
Copy link
Contributor

gak commented Aug 20, 2024

https://github.com/TBD54566975/ftl/actions/runs/10479096401/attempts/1

    harness.go:327: debug: fatal error: concurrent map writes
    harness.go:327: debug: 
    harness.go:327: debug: goroutine 2481 [running]:
    harness.go:327: debug: github.com/TBD54566975/ftl/internal/encryption.(*KMSEncryptor).getDerivedPrimitive(0xc0005a31c0, {0x7fd7242d3b78, 0xc00133f608})
@github-actions github-actions bot added the triage Issue needs triaging label Aug 20, 2024
@ftl-robot ftl-robot mentioned this issue Aug 20, 2024
Open
@github-actions github-actions bot removed the triage Issue needs triaging label Aug 20, 2024
@alecthomas
Copy link
Collaborator

You probably know this already after eyeballing it, but that map needs a lock around it.

@gak gak mentioned this issue Aug 21, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 21, 2024
@gak
fix: bug with subkeys, verify test fields on startup (#2444)
3da112c 
Fixes #2348
Fixes #2466
@gak gak closed this as completed in #2444 Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gak gak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: bug with subkeys, verify test fields on startup block/ftl
2 participants
@gak @alecthomas