Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow catch verbs in jvm with CatchRequest<Any> #2427

Closed
matt2e opened this issue Aug 19, 2024 · 0 comments · Fixed by #2428
Closed

Allow catch verbs in jvm with CatchRequest<Any> #2427

matt2e opened this issue Aug 19, 2024 · 0 comments · Fixed by #2428
Assignees
@stuartwdouglas
Labels
jvm

Comments

@matt2e
Copy link
Collaborator

matt2e commented Aug 19, 2024

We added the ability for catch verbs to have a request type of CatchRequest<OriginalRequestType> or CatchRequest<Any>, but that has is not yet supported in java

Test disabled here:
https://github.com/TBD54566975/ftl/blob/main/backend/controller/pubsub/integration_test.go#L143
@matt2e matt2e added the jvm label Aug 19, 2024
@ftl-robot ftl-robot mentioned this issue Aug 19, 2024
Open
stuartwdouglas added a commit that referenced this issue Aug 19, 2024
@stuartwdouglas
chore: Java tests for catch<Any>
57c5827 
fixes: #2427
@stuartwdouglas stuartwdouglas mentioned this issue Aug 19, 2024
Merged
stuartwdouglas added a commit that referenced this issue Aug 19, 2024
@stuartwdouglas
chore: Java tests for catch<Any>
dbfe253 
fixes: #2427
github-merge-queue bot pushed a commit that referenced this issue Aug 19, 2024
@stuartwdouglas
chore: Java tests for catch<Any> (#2428)
f9214f8 
fixes: #2427
safeer pushed a commit that referenced this issue Aug 19, 2024
@stuartwdouglas @safeer
chore: Java tests for catch<Any> (#2428)
1d3207b 
fixes: #2427
@ftl-robot ftl-robot mentioned this issue Aug 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuartwdouglas stuartwdouglas

Labels
jvm
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Java tests for catch<Any> block/ftl
2 participants
@stuartwdouglas @matt2e