Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse schema diff #2302

Closed
gak opened this issue Aug 8, 2024 · 0 comments · Fixed by #2323
Closed

Reverse schema diff #2302

gak opened this issue Aug 8, 2024 · 0 comments · Fixed by #2323
Assignees
Labels

Comments

@gak
Copy link
Contributor

gak commented Aug 8, 2024

It appears that the schema diff direction is the reverse direction. The CI is checking for new local changes against production, but showing the "new" changes are the remote ones. In the case below, "new" is the existing production controller.

We should probably reverse this unless there's a use case in the other direction.

Another option could be to optionally specify both endpoints like the regular diff command.

export FTL_ENDPOINT=http://production
content=$(ftl schema diff || true)
Usage: ftl schema diff [<other-endpoint>] [flags]

Print any schema differences between this cluster and another cluster. Returns
an exit code of 1 if there are differences.

Arguments:
  [<other-endpoint>]    Other endpoint URL to compare against. If this is not
                        specified then ftl will perform a diff against the local
                        schema.
@github-actions github-actions bot added the triage Issue needs triaging label Aug 8, 2024
@ftl-robot ftl-robot mentioned this issue Aug 8, 2024
@deniseli deniseli added next Work that will be be picked up next P1 and removed triage Issue needs triaging labels Aug 8, 2024
@stuartwdouglas stuartwdouglas self-assigned this Aug 12, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Aug 12, 2024
stuartwdouglas added a commit that referenced this issue Aug 12, 2024
github-merge-queue bot pushed a commit that referenced this issue Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants