Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devex annoyance: Model objects must be complete to avoid errors #2117

Closed
matt2e opened this issue Jul 19, 2024 · 1 comment · Fixed by #2120
Closed

Devex annoyance: Model objects must be complete to avoid errors #2117

matt2e opened this issue Jul 19, 2024 · 1 comment · Fixed by #2120
Assignees

Comments

@matt2e
Copy link
Collaborator

matt2e commented Jul 19, 2024

Context:

  • Partner project accepts webhooks from another team
    • That team has a very complicated payload with multiple levels of json
    • They have documentation for that data but it is incomplete and out of date
  • Partner project must provide a complete FTL model for the input to the webhook callback endpoint otherwise FTL will error whenever there is an unexpected key or different content
  • Partner project only cares about a very narrow part of the payload. Imagine wanting id and state but not caring what complex monster could be in content
@github-actions github-actions bot added the triage Issue needs triaging label Jul 19, 2024
@ftl-robot ftl-robot mentioned this issue Jul 19, 2024
@matt2e
Copy link
Collaborator Author

matt2e commented Jul 19, 2024

I told them to try []byte for the keys they didn't care about... I guess that has the effect we want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants