generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surface "could not get secrets" (and others) as errors #1959
Labels
Comments
Open
github-actions
bot
removed
triage
Issue needs triaging
next
Work that will be be picked up next
labels
Jul 3, 2024
alecthomas
changed the title
Surface "could not get secrets" (and other ModuleContext issues) to users (blocked by #1906)
Surface "could not get secrets" (and others) as errors
Jul 3, 2024
Based on our conversations there appears to be 2 goals for resolving this issue:
What I am seeing is that when the server is successfully terminated the controller will attempt to respawn the server as the controller aims to reach the target replica count. Naturally this complicates the task of reaching the second goal without impacting deployment resilience. |
jonathanj-square
added a commit
that referenced
this issue
Jul 4, 2024
jonathanj-square
added a commit
that referenced
this issue
Jul 4, 2024
jonathanj-square
added a commit
that referenced
this issue
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Change the retry code for pulling ModuleContext such that it differentiates between retryable errors and fatal errors. The easiest solution is probably to use gRPC status codes to differentiate.
Currently they are at debug level and the plugin just fails to start with no message.
The text was updated successfully, but these errors were encountered: