Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error for int64 not being a valid FTLType at build time #1920

Closed
matt2e opened this issue Jul 1, 2024 · 0 comments · Fixed by #1935
Closed

No error for int64 not being a valid FTLType at build time #1920

matt2e opened this issue Jul 1, 2024 · 0 comments · Fixed by #1935
Assignees
Labels

Comments

@matt2e
Copy link
Collaborator

matt2e commented Jul 1, 2024

type ExampleData struct {
	InvalidFieldType int64
}

This should error at build time because FTL does not support int64.
We should fix this for all the places where int64 could turn up, not just within structs, and also look at other types we don't support (float64 etc)

@github-actions github-actions bot added the triage Issue needs triaging label Jul 1, 2024
@ftl-robot ftl-robot mentioned this issue Jul 1, 2024
@matt2e matt2e added next Work that will be be picked up next P1 and removed triage Issue needs triaging labels Jul 1, 2024
@jonathanj-square jonathanj-square self-assigned this Jul 2, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Jul 2, 2024
jonathanj-square added a commit that referenced this issue Jul 8, 2024
fixes #1920

`int64` no longer projected to the FTL Int data type; `int` must be used
instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants