Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change from golang/protobuf to connect-go #17

Closed
alecthomas opened this issue May 2, 2023 · 0 comments · Fixed by #18
Closed

Change from golang/protobuf to connect-go #17

alecthomas opened this issue May 2, 2023 · 0 comments · Fixed by #18
Assignees
@alecthomas

Comments

@alecthomas
Copy link
Collaborator

This will unlock generated TypeScript clients.
@alecthomas alecthomas self-assigned this May 2, 2023
@alecthomas alecthomas added this to FTL May 2, 2023
@alecthomas alecthomas moved this to In Progress in FTL May 2, 2023
alecthomas added a commit that referenced this issue May 2, 2023
@alecthomas
refactor: replace grpc/grpc-go with bufbuild/connect-go
922063f 
This refactoring was mostly mechanical modulo a (seeming) bug with bidi
streams in Connect that causes them to just hang. I routed around it by
splitting SyncSchema into two methods, {Pull,Push}Schema.

Fixes #17
@alecthomas alecthomas mentioned this issue May 2, 2023
Merged
alecthomas added a commit that referenced this issue May 2, 2023
@alecthomas
refactor: replace grpc/grpc-go with bufbuild/connect-go
a7c7ab3 
This refactoring was mostly mechanical modulo a (seeming) bug with bidi
streams in Connect that causes them to just hang. I routed around it by
splitting SyncSchema into two methods, {Pull,Push}Schema.

Fixes #17
alecthomas added a commit that referenced this issue May 2, 2023
@alecthomas
refactor: replace grpc/grpc-go with bufbuild/connect-go
f43f2cf 
This refactoring was mostly mechanical modulo a (seeming) bug with bidi
streams in Connect that causes them to just hang. I routed around it by
splitting SyncSchema into two methods, {Pull,Push}Schema.

Fixes #17
alecthomas added a commit that referenced this issue May 2, 2023
@alecthomas
refactor: replace grpc/grpc-go with bufbuild/connect-go (#18)
5ad72bb 
This will let us call directly into gRPC servers from TypeScript.

This refactoring was mostly mechanical modulo a (seeming) bug with bidi
streams in Connect that causes them to just hang. I routed around it by
splitting SyncSchema into two methods, {Pull,Push}Schema.

Fixes #17
@github-project-automation github-project-automation bot moved this from In Progress to Done in FTL May 2, 2023
alecthomas added a commit that referenced this issue May 2, 2023
@alecthomas
refactor: replace grpc/grpc-go with bufbuild/connect-go (#18)
f8744c3 
This will let us call directly into gRPC servers from TypeScript.

This refactoring was mostly mechanical modulo a (seeming) bug with bidi
streams in Connect that causes them to just hang. I routed around it by
splitting SyncSchema into two methods, {Pull,Push}Schema.

Fixes #17
wesbillman pushed a commit that referenced this issue May 3, 2023
@alecthomas @wesbillman
refactor: replace grpc/grpc-go with bufbuild/connect-go (#18)
e39423d 
This will let us call directly into gRPC servers from TypeScript.

This refactoring was mostly mechanical modulo a (seeming) bug with bidi
streams in Connect that causes them to just hang. I routed around it by
splitting SyncSchema into two methods, {Pull,Push}Schema.

Fixes #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alecthomas alecthomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: replace grpc/grpc-go with bufbuild/connect-go block/ftl
1 participant
@alecthomas