Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ftl-project.toml should be generated if doesn't exist when running ftl init #1639

Closed
gak opened this issue Jun 4, 2024 · 3 comments · Fixed by #1648
Closed

ftl-project.toml should be generated if doesn't exist when running ftl init #1639

gak opened this issue Jun 4, 2024 · 3 comments · Fixed by #1648
Assignees
@deniseli

Comments

@gak
Copy link
Contributor

gak commented Jun 4, 2024

No description provided.

@github-actions github-actions bot added the triage Issue needs triaging label Jun 4, 2024
@ftl-robot ftl-robot mentioned this issue Jun 4, 2024
Open
@deniseli deniseli self-assigned this Jun 4, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Jun 4, 2024
@deniseli
Copy link
Contributor

deniseli commented Jun 4, 2024

I can grab this since I'm already working on #1561

@alecthomas
Copy link
Collaborator

IIRC the reason for this was so the VSCode extension would detect an FTL project, though strangely I do not have this issue in a new project I create.

@alecthomas
Copy link
Collaborator

Aaah, because it looks for ftl in bin/ftl I think @wesbillman ? What are the heuristics it uses?

Regardless, I think creating an ftl-project.toml in the Git root is a very good idea.

@deniseli deniseli mentioned this issue Jun 4, 2024
Merged
deniseli added a commit that referenced this issue Jun 5, 2024
@deniseli
feat: generate ftl-project.toml in the Git root if it DNE (#1648)
71fde02 
Fixes #1639

The current implementation ignores any `--config` flag values, but let
me know if we should default to creating the last _specified_ config
whenever one's provided. For that, I'd just move this code to the
resolver and add an `r.Config` check. I decided to minimize it purely to
operating on the default path because the specified paths may not
actually be at the Git root, which could make the new behavior a bit
more complex to comprehend. That said, there could be a good reason to
use the flag value that I didn't think of.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deniseli deniseli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: generate ftl-project.toml in the Git root if it DNE block/ftl
3 participants
@gak @alecthomas @deniseli