Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP errors are being surfaced as informational, not errors/warnings #1631

Closed
alecthomas opened this issue Jun 3, 2024 · 0 comments · Fixed by #1671
Closed

LSP errors are being surfaced as informational, not errors/warnings #1631

alecthomas opened this issue Jun 3, 2024 · 0 comments · Fixed by #1671
Assignees
@wesbillman @jonathanj-square
Labels
bug Something isn't working

Comments

@alecthomas
Copy link
Collaborator

image
@alecthomas alecthomas added the bug Something isn't working label Jun 3, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Jun 3, 2024
@ftl-robot ftl-robot mentioned this issue Jun 3, 2024
Open
@alecthomas alecthomas removed the triage Issue needs triaging label Jun 4, 2024
jonathanj-square added a commit that referenced this issue Jun 5, 2024
@jonathanj-square
fixes #1631
7a12500 
ensures error level is preserved in the round trip to protobuf conversion and back
@jonathanj-square jonathanj-square mentioned this issue Jun 5, 2024
Merged
jonathanj-square added a commit that referenced this issue Jun 5, 2024
@jonathanj-square
fixes #1631
fe3ae57 
ensures error level is preserved in the round trip to protobuf conversion and back
jonathanj-square added a commit that referenced this issue Jun 6, 2024
@jonathanj-square
fix: lsp error not showing correct error level #1631 (#1671)
112c6a9 
fixes #1631 

ensures error level is preserved in the round trip to protobuf
conversion and back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesbillman wesbillman

@jonathanj-square jonathanj-square

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: lsp error not showing correct error level #1631 block/ftl
3 participants
@alecthomas @wesbillman @jonathanj-square