Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSCode extension fails to run FTL in ftl-examples repo #1621

Closed
alecthomas opened this issue Jun 2, 2024 · 1 comment · Fixed by #1651
Closed

VSCode extension fails to run FTL in ftl-examples repo #1621

alecthomas opened this issue Jun 2, 2024 · 1 comment · Fixed by #1651
Assignees
@wesbillman
Labels
bug Something isn't working

Comments

@alecthomas
Copy link
Collaborator

image
@alecthomas alecthomas added the bug Something isn't working label Jun 2, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Jun 2, 2024
@ftl-robot ftl-robot mentioned this issue Jun 2, 2024
Open
@alecthomas
Copy link
Collaborator Author

I can only make this work by updating the extension setting for the ftl binary path to bin/ftl, even though ftl is in the active $PATH

@alecthomas alecthomas removed the triage Issue needs triaging label Jun 4, 2024
@wesbillman wesbillman mentioned this issue Jun 4, 2024
Merged
wesbillman added a commit that referenced this issue Jun 4, 2024
@wesbillman
fix: use path from where vscode was launched (#1651)
cec92e7 
Fixes #1621

This seems to better identify which ftl to use based on what `which ftl`
returns for a given workspace.

> [!NOTE]  
> The path will not be detected correctly if a workspace is changed via
File->Open...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesbillman wesbillman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use path from where vscode was launched block/ftl
2 participants
@alecthomas @wesbillman