Remove usage of json.RawMessage via go-runtime/encoding package
#1439
Labels
good first issue
Good for newcomers
Comments
Open
matt2e
changed the title
go-runtime/encoding package
deniseli
added a commit
that referenced
this issue
May 9, 2024
…esponse (#1454) Fixes #1439 Alec was right - the `[]byte` array was the right solution here! The response does come back encoded the same way it was when it was typed `json.RawMessage`. I confirmed in `backend/controller/ingress/handler_test.go` (which would fail if we made the `encoding.go` change without the `response.go` change) and also cleaned up the test a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
json.RawMessageis not a type that FTL supports. The only standard lib type we currently support istime.Time.However, currently, ingress requests and responses have
json.RawMessagefields in their structs. They are configured using thejsonstruct tag to be omitted from the output JSON when undefined.Now that we have support for omitempty (#1262), we no longer need to type these fields as
json.RawMessage. They are encoded as[]byteunderlying, but byte arrays are serialized to base64 strings by our custom encoder, rather than a human readable value.I haven't explored this fully to prove this works, but a reasonable option could be to convert the
json.RawMessagefields tostring, which would be human-readable.Make sure to remove the special case for
json.RawMessagein go-runtime/encoding/encoding.go as a part of this: linkThe text was updated successfully, but these errors were encountered: