Skip to content

Commit

Permalink
chore: enable wrapcheck for new code
Browse files Browse the repository at this point in the history
This has been disabled because manually wrapping all errors is very
tedious when iterating quickly, but it's come to the point where we need
to do this in order to provide useful errors. Recent examples of this
are #1885 and
#1879.
  • Loading branch information
alecthomas committed Jun 27, 2024
1 parent e4bba48 commit a047667
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
- name: Build Cache
uses: ./.github/actions/build-cache
- name: golangci-lint
run: golangci-lint run --out-format github-actions ./...
run: golangci-lint run --new-from-rev=HEAD~ --out-format github-actions ./...
- name: go-check-sumtype
shell: bash
run: go-check-sumtype ./... 2>&1 | to-annotation
Expand Down
1 change: 0 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ linters:
- interfacebloat
- tagalign
- nolintlint
- wrapcheck # We might want to re-enable this if we manually wrap all the existing errors with fmt.Errorf
- protogetter

linters-settings:
Expand Down
2 changes: 1 addition & 1 deletion Justfile
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ lint-frontend: build-frontend

# Lint the backend
lint-backend:
@golangci-lint run ./...
@golangci-lint run --new-from-rev=HEAD~ ./...

# Run live docs server
docs:
Expand Down

0 comments on commit a047667

Please sign in to comment.