fix: kill plugins when FTL stops (#3180)

block · Oct 24, 2024 · 7fdebbe · 7fdebbe
1 parent c3ad689
commit 7fdebbe
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/internal/buildengine/engine.go b/internal/buildengine/engine.go
@@ -1094,6 +1094,14 @@ func (e *Engine) watchForPluginEvents(originalCtx context.Context) {
 				e.rawEngineUpdates <- ModuleDeploySuccess{Module: event.Module}
 			}
 		case <-originalCtx.Done():
+			// kill all plugins
+			e.moduleMetas.Range(func(name string, meta moduleMeta) bool {
+				err := meta.plugin.Kill()
+				if err != nil {
+					log.FromContext(originalCtx).Errorf(err, "could not kill plugin")
+				}
+				return true
+			})
 			return
 		}
 	}