fix: allow non-FTL enums to exists in a module (#1748)

fixes #1747
block · Jun 12, 2024 · 787aa4f · 787aa4f
1 parent b4357a2
commit 787aa4f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/go-runtime/compile/schema.go b/go-runtime/compile/schema.go
@@ -949,9 +949,8 @@ func maybeVisitTypeEnumVariant(pctx *parseContext, node *ast.GenDecl, directives
 		return
 	}
 	typ := pctx.pkg.TypesInfo.TypeOf(t.Type)
-	if typeInterface, ok := typ.Underlying().(*types.Interface); ok {
+	if _, ok := typ.Underlying().(*types.Interface); ok {
 		// Type enums should not count as variants of themselves
-		pctx.enumInterfaces[t.Name.Name] = typeInterface
 		return
 	}
 

diff --git a/go-runtime/compile/testdata/one/one.go b/go-runtime/compile/testdata/one/one.go
@@ -173,3 +173,13 @@ func Http(ctx context.Context, req builtin.HttpRequest[Req]) (builtin.HttpRespon
 type DataWithType[T any] struct {
 	Value T
 }
+
+type NonFTLInterface interface {
+	NonFTLInterface()
+}
+
+type NonFTLStruct struct {
+	Name string
+}
+
+func (NonFTLStruct) NonFTLInterface() {}