generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: migrate configs and secrets to new extractor
- Loading branch information
Showing
7 changed files
with
259 additions
and
159 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| package call | ||
|
|
||
| import ( | ||
| "go/ast" | ||
| "go/types" | ||
| "strings" | ||
|
|
||
| "github.com/TBD54566975/ftl/go-runtime/schema/common" | ||
| "github.com/TBD54566975/golang-tools/go/analysis" | ||
| "github.com/TBD54566975/golang-tools/go/analysis/passes/inspect" | ||
| "github.com/TBD54566975/golang-tools/go/ast/inspector" | ||
| ) | ||
|
|
||
| const ( | ||
| ftlPkgPath = "github.com/TBD54566975/ftl/go-runtime/ftl" | ||
| ftlTopicHandleTypeName = "TopicHandle" | ||
| ) | ||
|
|
||
| // Extractor extracts all function calls. | ||
| var Extractor = common.NewExtractor("validate", (*Fact)(nil), Extract) | ||
|
|
||
| type Tag struct{} // Tag uniquely identifies the fact type for this extractor. | ||
| type Fact = common.DefaultFact[Tag] | ||
|
|
||
| func Extract(pass *analysis.Pass) (interface{}, error) { | ||
| //TODO: implement call metadata extraction (for now this just validates all calls) | ||
|
|
||
| in := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector) //nolint:forcetypeassert | ||
| nodeFilter := []ast.Node{ | ||
| (*ast.CallExpr)(nil), | ||
| } | ||
| in.Preorder(nodeFilter, func(n ast.Node) { | ||
| node := n.(*ast.CallExpr) //nolint:forcetypeassert | ||
| validateCallExpr(pass, node) | ||
| }) | ||
| return common.NewExtractorResult(pass), nil | ||
| } | ||
|
|
||
| // validateCallExpr validates all function calls | ||
| // checks if the function call is: | ||
| // - a direct verb call to an external module | ||
| // - a direct publish call on an external module's topic | ||
| func validateCallExpr(pass *analysis.Pass, node *ast.CallExpr) { | ||
| selExpr, ok := node.Fun.(*ast.SelectorExpr) | ||
| if !ok { | ||
| return | ||
| } | ||
| var lhsIdent *ast.Ident | ||
| if expr, ok := selExpr.X.(*ast.SelectorExpr); ok { | ||
| lhsIdent = expr.Sel | ||
| } else if ident, ok := selExpr.X.(*ast.Ident); ok { | ||
| lhsIdent = ident | ||
| } else { | ||
| return | ||
| } | ||
| lhsObject := pass.TypesInfo.ObjectOf(lhsIdent) | ||
| if lhsObject == nil { | ||
| return | ||
| } | ||
| var lhsPkgPath string | ||
| if pkgName, ok := lhsObject.(*types.PkgName); ok { | ||
| lhsPkgPath = pkgName.Imported().Path() | ||
| } else { | ||
| lhsPkgPath = lhsObject.Pkg().Path() | ||
| } | ||
| var lhsIsExternal bool | ||
| if !common.IsPathInPkg(pass.Pkg, lhsPkgPath) { | ||
| lhsIsExternal = true | ||
| } | ||
|
|
||
| if lhsType, ok := pass.TypesInfo.TypeOf(selExpr.X).(*types.Named); ok && lhsType.Obj().Pkg() != nil && | ||
| lhsType.Obj().Pkg().Path() == ftlPkgPath { | ||
| // Calling a function on an FTL type | ||
| if lhsType.Obj().Name() == ftlTopicHandleTypeName && selExpr.Sel.Name == "Publish" { | ||
| if lhsIsExternal { | ||
| common.Errorf(pass, node, "can not publish directly to topics in other modules") | ||
| } | ||
| } | ||
| return | ||
| } | ||
|
|
||
| if lhsIsExternal && strings.HasPrefix(lhsPkgPath, "ftl/") { | ||
| if sig, ok := pass.TypesInfo.TypeOf(selExpr.Sel).(*types.Signature); ok && sig.Recv() == nil { | ||
| // can not call functions in external modules directly | ||
| common.Errorf(pass, node, "can not call verbs in other modules directly: use ftl.Call(…) instead") | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.