[Refactor] Improve state management #222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove lastActiveTime property - remove block state subscription
- Separate Gas Prices subscription from main state - Separate Activity list subscription from main state and improve its regenaration - Separate exchange rates subscription from main state
…tor/state-subscriptions-improvement
…tor/state-subscriptions-improvement
…tor/state-subscriptions-improvement
fpezzola
changed the title
chk0912
reviewed
Jan 2, 2023
…tor/state-subscriptions-improvement
…tor/state-subscriptions-improvement
This is fixed now, can you re-check? |
|
Should be fixed by now, can you re-check? |
* feat: Add logic to use hotkey hook which will allow to navigate the extension with hotkeys. It is implemented in header so no need to include it on each page * feat: Update hotkey hook. Add util hotkeys with static values and getHotkeys function. Add more pages to hotkeys * feat: Add hotkey to open extension. Add certain hotkeys which are for specific pages. Add icon and popup to display hotkeys for current page * include popup with hotketys. upgrade package * add change to have current tab value * add validation to add new asset * Prepare hotkeys to work in Mac. Fix New asset issue, only allow it on assets view in popuppage * Fix focus on inputs issue. Fix onBack on networks page. * Change way to get OS to avoid Promise. Remove hotkeys icon, just allow alt+h to see hotkeys. Added preventDefault. Fix typo in some descriptions * Remove comment * Logic to avoid showing hotkeys that are not allowed by permissions * Add enable/disable hotkeys from preferences. Remove version number from settings and unstick logout button * Allow enable/disable hotkeys from preferences - include it in preferencesController, removed from AppStatecontroller. Show generic hotkeys in preferences page. Add 2 components to show hotkeys. Change hotkeys popup to improve design * Add new dialog with design only for hotkeys. Validate wherever it is needed if hotkeys are enabled. For all preferences pages we added the goback action. * Finish design based on Flair. * Remove unused state value * Change permissions workaround to include all kind of settings * Move all the hotkeys to one file. The others just read a component dictionary which has the hotkeys for them. * Action list like settings, preferences, account menu have numeric shortcuts. Also removed connectHardwareWallet from hotkeys util as it was being opened twice, move it to components dictionary. * Remove unused elements * Changed hotkeys to keyboard shortcuts in modal. Add Rest account to Home screen * Fix default value for hotkeys. Add ALT+O as hotkey in preferences page. Fix ALT+q definition. Add submit on enter for first use pages DefaultBrowser and welcome screens --------- Co-authored-by: Julián Ariel Martínez <[email protected]>
…tor/state-subscriptions-improvement
[Feat] Improve provider down status + switch to backup option
* feat: send to smart contract warning * feat: send to smart contract content edit
…ension into refactor/state-subscriptions-improvement
…:block-wallet/extension into refactor/state-subscriptions-improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name of the feature/issue
Improve state management.
Description
This PR aims to improve the application performance by:
lastActiveTimeto the UI since it changes very often.