Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put a limit to founder if target amount was not reached #227

Merged
merged 30 commits into from
Feb 13, 2025

Conversation

dangershony
Copy link
Member

image

@dangershony dangershony changed the title Put a limit to founder if amount was not reached Put a limit to founder if target amount was not reached Dec 21, 2024
@@ -82,6 +83,7 @@ public Task LookupInvestmentRequestsAsync(string nostrPubKey, string? senderNpub
{
var subscription = nostrClient.Streams.EventStream
.Where(_ => _.Subscription == subscriptionKey)
.Where(_ => _.Event.Tags.FindFirstTagValue("subject") == "Investment offer")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavidGershony what do you think about this as filter on the subscription?
I suppose the filter only actually happens in the client not the server, I am not sure it is possible to filter based on subject.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It happens on the client side, if you want to filter on the server side you need to add it to the filter we send to the relay, and you can add tags to the filter so should be possible to filter by subject.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try this next

@dangershony dangershony marked this pull request as ready for review February 5, 2025 11:50
@dangershony dangershony merged commit a9cc53a into main Feb 13, 2025
3 checks passed
@dangershony dangershony deleted the limit-if-target-was-not-reached branch February 13, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants