[legacy-framework] Change db/index.ts in new app template to use globalThis instead of global

[kripod]

What are the changes and their implications?

While Node.js has a non-standard global namespace object, version 12.4 introduced support for the standard globalThis object. Blitz requires Node.js >=12, so the change could be made without losing backwards compatibility.

Checklist

• Tests added for changes – N/A
• PR submitted to blitzjs.com for any user facing changes – N/A

[merelinguist]

Thanks again, @kripod! Could you have a look at the lint errors?

[kripod]

Sure! It turns out that only ESLint >=7 supports globalThis, with the built-in ES2020 parser. As a workaround, please consider adding the following code to the ESLint config:

{
  "globals": {
    "globalThis": false // Read-only
  }
}

[flybayer]

Hey thanks for the PR @kripod!!

I just did some digging and eslint-config-react-app just added support for eslint v7 relatively recently. So that means we can upgrade everything to v7 and then switch to globalThis.

I opened an issue for upgrade eslint. You're welcome to take that or let someone else. Once that issue is finished, then we can merge this.

However, for this PR you also need to change global to globalThis in all the other examples in the repo and in the new app template

[kripod]

Thanks for getting back to me!

Unfortunately, I’m not quite sure whether I’ll have time to do all of this.

[merelinguist]

@kripod No worries, I’ve finished up the rest for you. All that remains is for blitz-js/legacy-framework#661 to be closed, and then this can be merged.

[kripod]

@merelinguist Wonderful, thank you! 🙌

[flybayer]

Hey @kripod! We finally upgrade to eslint v7! So now we have one final issue it seems. Apparently we also have to add es2020 as the eslint environment. This needs added to the example apps and to the new app template eslint config file.

[kripod]

Wonderful, thank you! Unfortunately, I’m currently busy with a company projects, so I may not have time to complete the task…

[flybayer]

Ok no problem!

[wKovacs64]

Not sure what the implications are (if any) of enabling es2020 in the TS projects, but I added it to the app template and all examples.

[flybayer]

Perfect, thanks @kripod and @wKovacs64!!

@all-contributors add @kripod for code

[allcontributors]

@flybayer

I've put up a pull request to add @kripod! 🎉