Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Contributing.md: Add node-pty troubleshooting for WSL #419

Merged
merged 1 commit into from
May 4, 2020

Conversation

simondebbarma
Copy link
Collaborator

@simondebbarma simondebbarma commented May 4, 2020

Thanks to @silversoftwerks for the fix on blitz-js/legacy-framework#879

Type: Documentation

Closes: blitz-js/legacy-framework#879

What are the changes and their implications? ⚙️

A markdown file grows by 8 lines without any implication.

Checklist

  • Tests added for changes
  • Any added terminal logging uses packages/server/src/log.ts

Breaking change: No.

None.

Other information

Please suggest edits, if needed.

Thanks to silversoftwerks for the fix on #121
@simondebbarma simondebbarma self-assigned this May 4, 2020
@simondebbarma simondebbarma changed the title 📝 add node-pty troubleshooting for WSL add node-pty troubleshooting for WSL May 4, 2020
@simondebbarma simondebbarma changed the title add node-pty troubleshooting for WSL [Windows] add node-pty troubleshooting for WSL May 4, 2020
@simondebbarma simondebbarma added the os/windows Windows specific Issue/PR label May 4, 2020
@flybayer
Copy link
Member

flybayer commented May 4, 2020

Thank you!

@all-contributors add @simonpeterdebbarma for docs

@allcontributors
Copy link

@flybayer

I've put up a pull request to add @simonpeterdebbarma! 🎉

@flybayer flybayer changed the title [Windows] add node-pty troubleshooting for WSL Contributing.md: Add node-pty troubleshooting for WSL May 4, 2020
@flybayer flybayer merged commit 229272f into blitz-js:canary May 4, 2020
@simondebbarma simondebbarma deleted the node-pty-troubleshooting branch May 4, 2020 17:53
@itsdillon itsdillon changed the title Contributing.md: Add node-pty troubleshooting for WSL [legacy-framework] Contributing.md: Add node-pty troubleshooting for WSL Jul 7, 2022
itsdillon pushed a commit that referenced this pull request Aug 22, 2022
* add check for Minified React error #419 during codegen nextjs patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os/windows Windows specific Issue/PR status/done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document needed dependency on Ubuntu in WSL
2 participants