[legacy-framework] fix(server): force forward slashes in absolute imports

[wKovacs64]

Type: bug fix

Closes: blitz-js/legacy-framework#495

What are the changes and their implications? ⚙️

Sindre Sorhus to the rescue again. Slashified the result of path.join (it was trying to be helpful, but it wasn't in this particular case) to enforce forward slashes in absolute paths. A hack? Maybe. I don't know anymore.

Checklist

• Tests added for changes
• Any added terminal logging uses packages/server/src/log.ts

Breaking change: no

At least, I sure hope not.

Other information

[wKovacs64]

Still working on this, avert your eyes.

[simondebbarma]

@wKovacs64 Sure, I'm just organizing all Issues and PRs. Let me know if I assigned the wrong tags.

[wKovacs64]

@simonpeterdebbarma Oh you're good, that wasn't directed at you - more of a general warning for anyone who stumbled along (although I guess that should be obvious from being in draft). 🙂

[wKovacs64]

OK, I think this is ready.

The testing situation sucks because the implementation relies on Node's path module which returns different values based on the operating system on which the tests are running at the time. To deal with this, I added a platform check in the tests and pass the platform-specific paths based on that result. This is kind of bad because now there are 2 code paths (Windows and not-Windows) in the test suite for this module, where one executes on Windows and the other on macOS and Linux. That said, they will both be run once we have Windows as part of our OS matrix in CI (PR ready to go), so it should be clear when a change breaks one platform but not the other. An alternative approach might be to spy on path functions and mock their implementations per test but that felt worse. Open to other suggestions!