Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run codegen tasks after installing dependecies in the new command #3692

Merged
merged 3 commits into from
Aug 8, 2022

Conversation

beerose
Copy link
Contributor

@beerose beerose commented Aug 8, 2022

After some debugging, me and @dillonraphael figured out that the issue only happens with yarn and only on a fresh app creation (ie if you create a new app, remove node_modules, and install them again you won't get an error). Apparently, we can't modify node modules on the fly with yarn, so we're adding the codegen step to the post-install method in new.ts.

Closes: #3623

@beerose beerose requested a review from itsdillon as a code owner August 8, 2022 15:40
@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2022

🦋 Changeset detected

Latest commit: cc6c201

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
blitz Patch
@blitzjs/auth Patch
@blitzjs/next Patch
@blitzjs/rpc Patch
@blitzjs/codemod Patch
@blitzjs/config Patch
@blitzjs/generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@beerose beerose merged commit 41608c4 into main Aug 8, 2022
@beerose beerose deleted the run-codegen-yarn branch August 8, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants