Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[legacy-framework] Remove unnecessary runtime stream logging #369

Merged
merged 4 commits into from
May 1, 2020
Merged

[legacy-framework] Remove unnecessary runtime stream logging #369

merged 4 commits into from
May 1, 2020

Conversation

ryardley
Copy link
Collaborator

@ryardley ryardley commented Apr 30, 2020 •
edited
Loading

Type: bug fix

Closes: blitz-js/legacy-framework#885

What are the changes and their implications? ⚙️

  • Ready message only displays once
  • Refactors the synchronizer display out to a separate pipable preparing for potential refactor to its own package.
  • Uses the reporter as an event bus.
  • Extract out events to separate file
  • Passes streams not callbacks
  • Tests the stream component

Checklist

  • Tests added for changes
  • Any added terminal logging uses packages/server/src/log.ts

Breaking change: no

Other information

@ryardley ryardley requested a review from flybayer as a code owner April 30, 2020 15:18
@ryardley ryardley changed the title 213 remove runtime stream logging Remove runtime stream logging Apr 30, 2020
@ryardley ryardley mentioned this pull request Apr 30, 2020
Closed
13 tasks
@flybayer flybayer changed the title Remove runtime stream logging Remove unnecessary runtime stream logging May 1, 2020
@flybayer flybayer merged commit a406c82 into canary May 1, 2020
@flybayer flybayer deleted the 213-remove-runtime-stream-logging branch May 1, 2020 04:48
flybayer added a commit that referenced this pull request May 1, 2020
@flybayer
Revert "Remove unnecessary runtime stream logging (#369)"
c5abc46 
This reverts commit a406c82.
This was referenced May 1, 2020
Merged
Closed
flybayer added a commit that referenced this pull request May 1, 2020
@flybayer
Fix broken blitz start in 0.8.0-canary.0 by reverting #369 (#384)
e6ddb86 
(patch)
flybayer pushed a commit that referenced this pull request May 1, 2020
@ryardley @flybayer
Remove unnecessary runtime stream logging (#369)
70f09bd 
(patch)
@flybayer flybayer mentioned this pull request May 1, 2020
Merged
flybayer added a commit that referenced this pull request May 1, 2020
@flybayer
Remove unnecessary runtime stream logging (#369) (#386)
fd1cd78 
(ignore)
@itsdillon itsdillon changed the title Remove unnecessary runtime stream logging [legacy-framework] Remove unnecessary runtime stream logging Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flybayer flybayer flybayer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blitz synchronizer should report different during runtime than during start
2 participants
@ryardley @flybayer