Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Add lint rule 'no-anonymous default export' for new apps #337

Conversation

Shinyaigeek
Copy link

Type: linting, feature, Docs

Closes: blitz-js/legacy-framework#507

What are the changes and their implications? ⚙️

  • Adds rule no-anonymous-default-export to eslint config in templates
  • Adds rule no-anonymous-default-export to eslint config in each examples
  • fix: change default exported anonymous component in examples -> default exported Named component
  • fix: change default exported anonymous component in USER_GUIDE.md -> default exported Named component
  • fix: change default exported anonymous function in @blitz/server -> default exported Named function

Checklist

N/A

Breaking change: no

Other information

N/A

@flybayer
Copy link
Member

Thank you @Shinyaigeek!! Looks good to me — we'll wait on @ryardley

@all-contributors add @Shinyaigeek for code

@allcontributors
Copy link

@flybayer

I've put up a pull request to add @Shinyaigeek! 🎉

@flybayer
Copy link
Member

I guess one question is whether to have this as a warning or an error. I was initially thinking error.

@Shinyaigeek
Copy link
Author

@flybayer
Sure, enforce means error rather than warn, sorry 🙏
I fixed this in 3e951a7

@flybayer flybayer changed the title update eslint config to enforce no-anonymous default export for new app and generators Add lint rule 'no-anonymous default export' for new apps Apr 30, 2020
@flybayer flybayer merged commit b417a6d into blitz-js:canary Apr 30, 2020
@itsdillon itsdillon changed the title Add lint rule 'no-anonymous default export' for new apps [legacy-framework] Add lint rule 'no-anonymous default export' for new apps Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce no-anonymous-default-export for new app and generators
4 participants