Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Update material-ui recipe — remove @mui/styles #3076

Merged
merged 3 commits into from
Dec 20, 2021

Conversation

JuanM04
Copy link

@JuanM04 JuanM04 commented Dec 17, 2021

What are the changes and their implications?

It turned out @mui/styles is deprecated, so I updated the recipe following their TypeScript example.

Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting the following error when installing material-ui recipe:

  ERROR { value:
       , loc: null, type: Literal, comments: null, regex: null } does
       not match type string

 - , loc: null, type: Literal, comments: null, regex: null } does not 
   match type string
 -PredicateType.BaseTy (/Users/aleksandra/blitz/node_modules/ast-types/
  e.assert            lib/types.js:14:19)
 - (/Users/aleksandra/blitz/node_modules/recast/lib/printer.js:1919:22)

 -FastPath.ea (/Users/aleksandra/blitz/node_modules/recast/lib/fast-pat
  h          h.js:148:13)
 -printStatementSeq (/Users/aleksandra/blitz/node_modules/recast/lib/pr
  ence             inter.js:1892:10)
 -  (/Users/aleksandra/blitz/node_modules/recast/lib/printer.js:175:63)
 -FastPath.ca (/Users/aleksandra/blitz/node_modules/recast/lib/fast-pat
  l          h.js:125:18)
 -genericPrintNoPa (/Users/aleksandra/blitz/node_modules/recast/lib/pri
  ens             nter.js:175:29)
 -genericPri (/Users/aleksandra/blitz/node_modules/recast/lib/printer.j
  t         s:123:30)
 -print (/Users/aleksandra/blitz/node_modules/recast/lib/printer.js:77:
       15)
 -  (/Users/aleksandra/blitz/node_modules/recast/lib/patcher.js:151:28)
ERROR 
 Error  { value: 
, loc: null, type: Literal, comments: null, regex: null } does not match type string
error stack:
• types.js:14 BaseType.assert
    node_modules/ast-types/lib/types.js:14:19

• printer.js:1919 <anonymous>
    node_modules/recast/lib/printer.js:1919:22

• fast-path.js:148 each
    node_modules/recast/lib/fast-path.js:148:13

• printer.js:1892 printStatementSequence
    node_modules/recast/lib/printer.js:1892:10

• printer.js:175 <anonymous>
    node_modules/recast/lib/printer.js:175:63

• fast-path.js:125 call
    node_modules/recast/lib/fast-path.js:125:18

• printer.js:175 genericPrintNoParens
    node_modules/recast/lib/printer.js:175:29

• printer.js:123 genericPrint
    node_modules/recast/lib/printer.js:123:30

• printer.js:77 print
    node_modules/recast/lib/printer.js:77:15

• patcher.js:151 <anonymous>
    node_modules/recast/lib/patcher.js:151:28

@beerose beerose changed the title Updated Material-UI recipe Update material-ui recipe — remove @mui/styles Dec 20, 2021
@beerose beerose merged commit 77ad2c0 into canary Dec 20, 2021
@beerose beerose deleted the mui-sytles branch December 20, 2021 14:19
@itsdillon itsdillon changed the title Update material-ui recipe — remove @mui/styles [legacy-framework] Update material-ui recipe — remove @mui/styles Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants