[legacy-framework] Load env vars for blitz new command - ignore cached variables #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
flybayer
reviewed
Dec 8, 2021
nextjs/packages/next-env/index.ts
Outdated
Comment on lines
70
to
71
| dev?: boolean, | ||
| log: Log = console | ||
| log: Log = console, | ||
| ignoreCache = false |
There was a problem hiding this comment.
So ignoreCache is what fixes the issue right? Makes sense.
It would be slightly better to add an object as the new param as {ignoreCache}. I always fine unnamed function params error prone, especially when we are in a fork situation.
There was a problem hiding this comment.
Why did you remove dev?
Not used in the function body
There was a problem hiding this comment.
The change was introduced here: 5d9fcd2
There was a problem hiding this comment.
Not used in the function body
Normally I would agree, but in the context of a fork, this makes upstream merges more difficult
beerose
force-pushed
the
fix-sqlite-init
branch
from
71c8893 to
537c8b2
Compare
flybayer
approved these changes
Dec 9, 2021
itsdillon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: blitz-js/legacy-framework#370
What are the changes and their implications?
Not sure if that would be the best way to handle that (I might have missed something), so would love some suggestions if it's not.
Bug Checklist
Feature Checklist
canarybranch)