[legacy-framework] Move display package to nextjs fork #2989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
12 tasks
beerose
commented
Nov 30, 2021
nextjs/packages/next/package.json
Outdated
| @@ -111,6 +112,7 @@ | |||
| "node-libs-browser": "^2.2.1", | |||
| "npm-which": "^3.0.1", | |||
| "null-loader": "4.0.1", | |||
| "ora": "^5.3.0", | |||
There was a problem hiding this comment.
Probably can import from next/dist/compiled/ora
flybayer
reviewed
Nov 30, 2021
Comment on lines
86
to
88
| const withWarning = (str: string) => { | ||
| return `⚠️ ${c.yellow(str)}` | ||
| } |
Comment on lines
98
to
100
| const withX = (str: string) => { | ||
| return `${c.red.bold('✕')} ${str}` | ||
| } |
There was a problem hiding this comment.
remove in favor of tslog.error
Comment on lines
139
to
141
| const warning = (msg: string) => { | ||
| console.log(withCaret(withWarning(msg))) | ||
| } |
beerose
dismissed stale reviews from imcodingideas and kodiakhq[bot]
via
f0fcad0
itsdillon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of blitz-js/legacy-framework#391
I haven't modified or deleted display package functions yet.
Bug Checklist
Feature Checklist
canarybranch)