Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Add Passenger recipe #2890

Merged
merged 6 commits into from
Nov 10, 2021

Conversation

netwarex
Copy link

Closes: blitz-js/legacy-framework#213

What are the changes and their implications?

Bug Checklist

  • Integration test added (see test docs if needed)

Feature Checklist

Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

I'm not sure about the passenger.js script though. Left a comment there.

@netwarex
Copy link
Author

netwarex commented Nov 2, 2021

Thanks @beerose! The passenger.js topic has been resolved :)

recipes/passenger/index.ts Outdated Show resolved Hide resolved
Co-authored-by: Aleksandra Sikora <[email protected]>
@beerose beerose changed the title Add Passenger support Add Passenger recipe Nov 3, 2021
@beerose
Copy link
Contributor

beerose commented Nov 3, 2021

Hey @netwarex! I'm going to merge this PR, but could you update your branch with the latest canary? Usually, I'd do it myself, but I think the option to update this branch by maintainers is disabled.

You can also check this option:
Screenshot 2021-11-03 at 15 14 05
so that we can update this PR in case something else gets merged in the meantime.

@netwarex
Copy link
Author

netwarex commented Nov 6, 2021

Hi @beerose I can't see this option in this merge request, but I have updated with the latest changes the branch :)

@beerose
Copy link
Contributor

beerose commented Nov 9, 2021

Hey @netwarex, I'm sorry about that, but the branch is not updated with canary. Could you update it again and I'll try to merge it as soon as I can so that nothing else gets merged in the meantime?
Unfortunately, I can't push to your branch, so can't do it myself.

@netwarex
Copy link
Author

netwarex commented Nov 9, 2021

Hey @beerose! I did it again! :)

Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing 🙏

@netwarex
Copy link
Author

Done ;)

@beerose beerose merged commit 32983cb into blitz-js:canary Nov 10, 2021
@blitzjs-bot
Copy link
Contributor

Added @netwarex contributions for doc and code

@itsdillon itsdillon changed the title Add Passenger recipe [legacy-framework] Add Passenger recipe Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phusion Passenger support
4 participants