Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] show an error if model name is invalid in blitz generate #2802

Merged
merged 10 commits into from
Oct 11, 2021
Merged

[legacy-framework] show an error if model name is invalid in blitz generate #2802

Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ff5dd8b
add err when model name not passed to cli generate
martinsaxa Oct 5, 2021
38cd52a
Merge branch 'canary' into canary
martinsaxa Oct 6, 2021
e66947d
check modelName for invalid characters
martinsaxa Oct 6, 2021
3d9c33b
Merge branch 'canary' of https://github.com/martinsaxa/blitz into canary
martinsaxa Oct 6, 2021
eaddacd
Merge branch 'blitz-js:canary' into canary
martinsaxa Oct 9, 2021
5dbd4fb
validateModelName also check for invalid char
martinsaxa Oct 9, 2021
c83acf4
Update commit message
martinsaxa Oct 11, 2021
d5af13f
Update packages/cli/src/commands/generate.ts
beerose Oct 11, 2021
ff052bb
lint
beerose Oct 11, 2021
11a1a98
Merge branch 'canary' into canary
beerose Oct 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/cli/src/commands/generate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,9 @@ export class Generate extends Command {
`Names ${RESERVED_MODEL_NAMES} or their plurals cannot be used as model names`,
)
}
if (!/^[A-Za-z][A-Za-z0-9_]*$/.test(modelName)) {
throw new Error(`Model name cannot contain any special characters`)
martinsaxa marked this conversation as resolved.
Show resolved Hide resolved
}
}

async run() {
Expand Down