[legacy-framework] display an error if loading a module fails in blitz console #2792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 3, 2021
beerose
changed the title
beerose
reviewed
Oct 4, 2021
|
Added @g3offrey contributions for code |
g3offrey
added a commit
to g3offrey/blitz
that referenced
this pull request
Oct 5, 2021
itsdillon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: blitz-js/legacy-framework#295
What are the changes and their implications?
I decided to simply log the error that appears at the loading of the module.
I initially thought about a verbose mode, but I finally think this error should always be displayed.
If expert users need more details they can still enable additional logging using the DEBUG env var.
I'll check if there is some documentation about the DEBUG scopes, if not I'll be glad to create it.
Edit : I created it here : blitz-js/blitzjs.com#560
Bug Checklist
Feature Checklist