Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] add tsdoc comments for withRouter and useRouter functions #2784

Merged
merged 7 commits into from
Oct 11, 2021

Conversation

maybebored
Copy link

@maybebored maybebored commented Oct 2, 2021

Part of blitz-js/legacy-framework#32

What are the changes and their implications?

Adds TS Doc to some components so they get picked up in VS Code

Bug Checklist

  • Integration test added (see test docs if needed)

Feature Checklist

@maybebored maybebored marked this pull request as ready for review October 3, 2021 05:18
@beerose
Copy link
Contributor

beerose commented Oct 6, 2021

Hey @maybebored, I don't see any updates that you mentioned in the comment: blitz-js/legacy-framework#32

@maybebored
Copy link
Author

Hey @maybebored, I don't see any updates that you mentioned in the comment: #2144 (comment)

Ahh my bad, sorry, forgot to push!

Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Left a few suggestions

packages/core/src/router/index.tsx Outdated Show resolved Hide resolved
packages/core/src/router/index.tsx Outdated Show resolved Hide resolved
packages/core/src/router/index.tsx Outdated Show resolved Hide resolved
packages/core/src/router/index.tsx Outdated Show resolved Hide resolved
nextjs/packages/next/client/image.tsx Outdated Show resolved Hide resolved
nextjs/packages/next/client/script.tsx Outdated Show resolved Hide resolved
@maybebored maybebored requested a review from beerose October 10, 2021 10:55
@beerose beerose changed the title #2144 Add TSDOC add tsdoc comments for withRouter and useRouter functions Oct 11, 2021
@beerose beerose merged commit cfdfb69 into blitz-js:canary Oct 11, 2021
@blitzjs-bot
Copy link
Contributor

Added @maybebored contributions for code

@maybebored maybebored deleted the #2144-tsdoc branch October 18, 2021 17:35
@itsdillon itsdillon changed the title add tsdoc comments for withRouter and useRouter functions [legacy-framework] add tsdoc comments for withRouter and useRouter functions Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants