[legacy-framework] Add useQuery pagination & add pagination to store example #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoa...!! This is amazing!! Fantastic work!! @all-contributors add @eliasjohansson for code |
|
I've put up a pull request to add @eliasjohansson! 🎉 |
flybayer
changed the title
itsdillon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Feature
Closes: blitz-js/legacy-framework#820
What are the changes and their implications? ⚙️
Blitz
useQueryusesusePaginatedQueryfromreact-querywhen passing{paginated: true}in options. Also added type for the options argument, it extends react-queryQueryOptions.Added new page in the existing Store example that shows how it can be used.
/products/paginatedBreaking change: no
Other information
The return type of the second value from
useQueryis now conditional, based on if paginated is true.I am unsure of which or if any of the new types should be exported.
First PR, happy to be here!